Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove surf support #147

Open
msrd0 opened this issue Mar 7, 2024 · 2 comments
Open

Remove surf support #147

msrd0 opened this issue Mar 7, 2024 · 2 comments

Comments

@msrd0
Copy link
Collaborator

msrd0 commented Mar 7, 2024

surf support is outdated and surf is no longer maintained. It should be removed from this crate.

ORIGINAL ISSUE TEXT:
The surf crate has not only seen no releases in the last two years, but also the git repository has seen no commit in the last two years. It depends on outdated version like tokio 0.2 and there does not seem to be any effort to make a new releases with more up to date dependencies. However, it is the only way this crate works with async-std.

I personally am fine with tokio-only libraries and would vote to remove surf in an upcoming release. Are there any users of the surf backend of this library? Would you be able to upgrade to the reqwest backend? What are your reasons for still using surf despite the default client being reqwest for a while now?

@msrd0
Copy link
Collaborator Author

msrd0 commented Mar 7, 2024

The maintainer of surf said it should be considered unmaintained: http-rs/surf#352 (comment)

@Empty2k12
Copy link
Collaborator

This has been open for close to a month without anyone indicating that surf is required. Renaming this ticket.

@Empty2k12 Empty2k12 changed the title RFC: Remove surf support Remove surf support Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants