Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paths/notificationRules - GET definition contains query param checkID which does not seem to be implemented #563

Open
karel-rehor opened this issue Oct 6, 2022 · 0 comments

Comments

@karel-rehor
Copy link

While writing tests for the endpoint notificationRules I've tried to filter using the checkID parameter defined in common/paths/notificationRules.yml but it seems to have no affect. Even illegal ID Values (e.g. ?checkID=12345678 should throw an error that ID must have a length of 16 bytes) are passed without issue.

Is this the remains of an idea that was later implemented differently and should be removed, or is this something awaiting implementation?

common/paths/notificationRules.yml

get:
  operationId: GetNotificationRules
  tags:
    - NotificationRules
  summary: List all notification rules
  parameters:
    - $ref: "../parameters/TraceSpan.yml"
    - $ref: "../parameters/Offset.yml"
    - $ref: "../parameters/Limit.yml"
    - in: query
      name: orgID
      required: true
      description: Only show notification rules that belong to a specific organization ID.
      schema:
        type: string
    - in: query
      name: checkID
      description: Only show notifications that belong to the specific check ID.
      schema:
        type: string
    - in: query
      name: tag
      description: Only return notification rules that "would match" statuses which contain the tag key value pairs provided.
      schema:
        type: string
        pattern: ^[a-zA-Z0-9_]+:[a-zA-Z0-9_]+$
        example: env:prod
  responses:
    "200":
      description: A list of notification rules
      content:
        application/json:
          schema:
            $ref: "../schemas/NotificationRules.yml"
    default:
      description: Unexpected error
      content:
        application/json:
          schema:
            $ref: "../schemas/Error.yml"
post:
  operationId: CreateNotificationRule
  tags:
    - NotificationRules
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant