You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So QueryAPI, DeleteAPI, InvokableScriptsAPI have a strong reference to the client and the client has strong references to them, creating a reference cycle that leads to a memory leak. None of these objects can be deinitialized.
Since none of these classes store anything mutable, I suggest using structs instead of classes here and making these properties computed:
Thank you for using our client and for taking the time to contribute to its development. I'm thrilled to see your Pull Request #64, which addresses the issue you've encountered.
I appreciate your initiative in improving the project and would be more than happy to assist you with your Pull Request. If you have any questions or need further guidance as you refine your submission, please feel free to reach out.
Looking forward to working together to enhance our client.
I looked at the code and noticed strong reference cycles:
and inside QueryAPI, DeleteAPI, InvokableScriptsAPI:
So QueryAPI, DeleteAPI, InvokableScriptsAPI have a strong reference to the client and the client has strong references to them, creating a reference cycle that leads to a memory leak. None of these objects can be deinitialized.
Since none of these classes store anything mutable, I suggest using structs instead of classes here and making these properties computed:
InfluxDBClient
could also be a struct, and it would be ideal if all these types conformed to theSendable
protocol.The text was updated successfully, but these errors were encountered: