Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2.Error does not implement errors.Unwrap correctly #310

Closed
pabigot opened this issue Feb 25, 2022 · 0 comments · Fixed by #311
Closed

http2.Error does not implement errors.Unwrap correctly #310

pabigot opened this issue Feb 25, 2022 · 0 comments · Fixed by #311

Comments

@pabigot
Copy link
Contributor

pabigot commented Feb 25, 2022

#239 included addition of the errors package Unwrap() functionality to http2.Error, but the implementation does not fulfill the contract of that function, which is to return the wrapped error. Instead it returns a new untyped error containing only the text of the wrapped error.

This prevents applications from using Unwrap() (and so errors.As) correctly to get access to url.Error or net.Error instances that convey additional information about why the operation failed, making it more difficult to resolve #292.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant