From 4c304bb189eae02fbf936be8f930371477e4fc65 Mon Sep 17 00:00:00 2001 From: Sehyo Chang Date: Sat, 2 Jul 2022 19:03:40 -0700 Subject: [PATCH 1/3] add more debugging in case of timeout --- Cargo.lock | 2 +- crates/fluvio-socket/Cargo.toml | 2 +- crates/fluvio-socket/src/multiplexing.rs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 3997fc6cb8..701fe8846e 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2316,7 +2316,7 @@ dependencies = [ [[package]] name = "fluvio-socket" -version = "0.11.5" +version = "0.11.6" dependencies = [ "async-channel", "async-lock", diff --git a/crates/fluvio-socket/Cargo.toml b/crates/fluvio-socket/Cargo.toml index bd58555f30..8bdb6ded4b 100644 --- a/crates/fluvio-socket/Cargo.toml +++ b/crates/fluvio-socket/Cargo.toml @@ -1,6 +1,6 @@ [package] name = "fluvio-socket" -version = "0.11.5" +version = "0.11.6" edition = "2021" authors = ["Fluvio Contributors "] description = "Provide TCP socket wrapper for fluvio protocol" diff --git a/crates/fluvio-socket/src/multiplexing.rs b/crates/fluvio-socket/src/multiplexing.rs index 9a0ce602f0..40243fd4c6 100644 --- a/crates/fluvio-socket/src/multiplexing.rs +++ b/crates/fluvio-socket/src/multiplexing.rs @@ -170,7 +170,7 @@ impl MultiplexerSocket { Err(IoError::new( ErrorKind::TimedOut, - format!("Timed out waiting for response. API_KEY={}, CorrelationId={}", R::API_KEY, correlation_id), + format!("Timed out: {} secs waiting for response. API_KEY={}, CorrelationId={}", *MAX_WAIT_TIME,R::API_KEY, correlation_id), ).into()) }, From 02d8c7cdbf058d77f72aeaba9e99ca019c19e1e8 Mon Sep 17 00:00:00 2001 From: Sehyo Chang Date: Sat, 2 Jul 2022 19:04:34 -0700 Subject: [PATCH 2/3] add success diag --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c8c6342dd7..16e00920f2 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -694,12 +694,12 @@ jobs: env: SKIP_TEST_CONNECTOR: true - name: Run diagnostics - if: ${{ !success() }} + # if: ${{ !success() }} timeout-minutes: 5 run: fluvio cluster diagnostics --k8 - name: Upload diagnostics timeout-minutes: 5 - if: ${{ !success() }} + # if: ${{ !success() }} uses: actions/upload-artifact@v2 with: name: k8_${{ matrix.run }}-${{ matrix.test }}-log From 933afb6d12f17acd6b26934cd85b9343b0fdfeb0 Mon Sep 17 00:00:00 2001 From: Sehyo Chang Date: Sun, 3 Jul 2022 09:09:04 -0700 Subject: [PATCH 3/3] revert --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 16e00920f2..c8c6342dd7 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -694,12 +694,12 @@ jobs: env: SKIP_TEST_CONNECTOR: true - name: Run diagnostics - # if: ${{ !success() }} + if: ${{ !success() }} timeout-minutes: 5 run: fluvio cluster diagnostics --k8 - name: Upload diagnostics timeout-minutes: 5 - # if: ${{ !success() }} + if: ${{ !success() }} uses: actions/upload-artifact@v2 with: name: k8_${{ matrix.run }}-${{ matrix.test }}-log