Validate VERSION will be parsable by semver at runtime

[tjtelan]

Related: #2949

Due to how we include the platform version number in the CLI, if there is any leading/trailing whitespace, parsing for semver may fail. We handle this case inconsistently.

fluvio/crates/fluvio-cli/src/lib.rs

Line 16 in d2b7ccf

pub(crate) const VERSION: &str = include_str!("../../../VERSION");

---

fluvio version can handle whitespace

fluvio/crates/fluvio-cli/src/version.rs

Line 23 in d2b7ccf

self.print("Fluvio CLI", crate::VERSION.trim());

But fluvio install/update (and many other places) do not include .trim()

fluvio/crates/fluvio-cli/src/install/update.rs

Line 282 in d2b7ccf

Version::parse(crate::VERSION).expect("Fluvio CLI 'VERSION' should be a valid semver");

There is no known workaround after compilation, but VERSION requirements should also be less strict. We should support basic whitespace trimming and address the root issue.

And rather than handle case-by-case, we should validate that VERSION is valid during buildtime. But the CLI build should fail in cases when VERSION can't be parsed due to actual semver validity.

[jamrok]

Hey @tjtelan, I'd like to work on this. Can you assign it to me?

[tjtelan]

Hi @jamrok, thanks for the interest! Sure, I can assign to you

[github-actions]

Stale issue message