Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Can't parse output of helm version --short with SemVer #3094

Open
ozgrakkurt opened this issue Mar 23, 2023 · 5 comments
Open

[Bug]: Can't parse output of helm version --short with SemVer #3094

ozgrakkurt opened this issue Mar 23, 2023 · 5 comments
Labels
bug Something isn't working help wanted Good issue for community involvement k8/helm technical debt

Comments

@ozgrakkurt
Copy link
Contributor

Hey,

I get this output with helm installed on Fedora using dnf install helm:

[ozgur@nobara-pc fluvio]$ helm version --short
v3.11

And when I run flvd cluster check I get:

 📝 Checking Helm - 
2023-03-23T10:37:32.969384Z DEBUG fluvio_command: Executing> helm version
Could not parse Version

Seems like this might be cause by semver not parsing v3.11.

Maybe this should be handled before calling semver::Version::parse?

@ozgrakkurt ozgrakkurt added the bug Something isn't working label Mar 23, 2023
@ozgrakkurt
Copy link
Contributor Author

ozgrakkurt commented Mar 23, 2023

I see that it is already handled here: https://github.com/infinyon/fluvio-helm/blob/fec48a46c5181ca5a1f1ad56e6a2b3dadfec68a8/src/lib.rs#L365

It seems to fail parsing because there is no patch version

@ozgrakkurt
Copy link
Contributor Author

Installing helm like this fixed the issue.

@ozgrakkurt
Copy link
Contributor Author

Re-opening this since maybe it would be good to handle helm version not returning patch number.

@ozgrakkurt ozgrakkurt reopened this Mar 23, 2023
@sehz
Copy link
Contributor

sehz commented Mar 23, 2023

Yes

@sehz sehz added k8/helm help wanted Good issue for community involvement labels Mar 23, 2023
@github-actions
Copy link

Stale issue message

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 31, 2023
@morenol morenol reopened this May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Good issue for community involvement k8/helm technical debt
Projects
None yet
Development

No branches or pull requests

3 participants