Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: CLI package publish gets skipped in re-runs #3009

Open
tjtelan opened this issue Feb 24, 2023 · 0 comments
Open

Release: CLI package publish gets skipped in re-runs #3009

tjtelan opened this issue Feb 24, 2023 · 0 comments
Labels
bug Something isn't working build-release CI DX/GENERAL Developer Experience General technical debt

Comments

@tjtelan
Copy link
Contributor

tjtelan commented Feb 24, 2023

Related: #2998

Related workflow run: https://github.com/infinyon/fluvio/actions/runs/4265630810/jobs/7425189192


The use this check for idempotence for publish/release. The intent is to prevent unnecessary re-building and re-publishing fluvio CLI.

# Check that this release does not already exist by trying to download it
- name: Attempt to install Fluvio CLI
id: check_fluvio
continue-on-error: true
env:
CHANNEL_TAG: ${{ env.VERSION }}
run: make curl-install-fluvio

However, this condition is used for individual packages as well. We skip if only the fluvio binary is found.

Consequently, based on the current order of publish (fluvio CLI is first), runs that fail during package publish will always get skipped on re-runs.

We need a few things to make testing this easier to do in the future:

  • Publish the fluvio CLI last
  • Option to ignore checks so we always run build and publish steps

Alternate approach

If we had package-level checks for publish/release, that would be equally as impactful.

@tjtelan tjtelan added bug Something isn't working build-release technical debt CI DX/GENERAL Developer Experience General labels Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build-release CI DX/GENERAL Developer Experience General technical debt
Projects
None yet
Development

No branches or pull requests

1 participant