Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm packages are not rebuilt after editing #2879

Open
nacardin opened this issue Dec 14, 2022 · 1 comment
Open

Helm packages are not rebuilt after editing #2879

nacardin opened this issue Dec 14, 2022 · 1 comment
Labels
help wanted Good issue for community involvement technical debt

Comments

@nacardin
Copy link
Contributor

When running package in k8-util/helm/Makefile, the helm chart packages are not rebuilt after editing chart templates.

@tjtelan
Copy link
Contributor

tjtelan commented Dec 14, 2022

Possibly we could move the creation of these .tgz files into the fluvio-cluster build script. That way we can change the trigger to rebundle helm charts by watching for changes in the entire directory.

Or the makefile rule can just always recreate new .tgz with temp names. We'd save them (by rename) if:

  1. No tgz exists previously
  2. New ones are different than the old ones

(The intent behind the file rename dance is to prevent running fluvio-cluster's build.rs for every build, since we'd prevent modifying the mtime of the .tgz) - https://doc.rust-lang.org/cargo/reference/build-scripts.html#rerun-if-changed

println!("cargo:rerun-if-changed=../../k8-util/helm/pkg_sys/fluvio-chart-sys.tgz");
println!("cargo:rerun-if-changed=../../k8-util/helm/pkg_app/fluvio-chart-app.tgz");

@sehz sehz added help wanted Good issue for community involvement technical debt labels Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Good issue for community involvement technical debt
Projects
None yet
Development

No branches or pull requests

3 participants