Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Move build artifact publish steps #2544

Open
tjtelan opened this issue Aug 11, 2022 · 1 comment
Open

[CI] Move build artifact publish steps #2544

tjtelan opened this issue Aug 11, 2022 · 1 comment
Labels
build-release CI good first issue Good for newcomers no-stale Opt-out of closing issue due to no activity technical debt

Comments

@tjtelan
Copy link
Contributor

tjtelan commented Aug 11, 2022

Currently we create and push these artifacts from staging. Since we use Bors to perform merges, that means each new build attempt has a new git commit that gets built into the binaries.

If a staging CI job fails, we may not be able to continue from the same commit. And staging builds fail often enough that we should take it into consideration.

We should have a new workflow that runs on push event to the master branch. The final rust binaries and docker images should originate the commits that correlate to master.

build_binaries:

docker_push:

bump_github_release:

publish_github_helm_pkg:

publish_github_binaries:

@tjtelan tjtelan added good first issue Good for newcomers build-release technical debt CI no-stale Opt-out of closing issue due to no activity labels Aug 11, 2022
@sehz
Copy link
Contributor

sehz commented Aug 11, 2022

New workflow doesn't have to rebuild artifacts. Can use binaries from staging build since we are using bors to guarantee order

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-release CI good first issue Good for newcomers no-stale Opt-out of closing issue due to no activity technical debt
Projects
None yet
Development

No branches or pull requests

2 participants