Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New colors theme method and improved colors theme docs #726

Open
blake-mealey opened this issue Oct 14, 2020 · 2 comments
Open

New colors theme method and improved colors theme docs #726

blake-mealey opened this issue Oct 14, 2020 · 2 comments

Comments

@blake-mealey
Copy link

Hey, a couple of quick suggestions I'm happy to submit a PR for if you're interested:

  1. Add a new colors theme method command which points to magenta

I like to use a distinct and consistent color when telling the user they can use another command to help with something (e.g. from my CLI `This action requires a logged in user. Run ${magenta(`${brand} login`)} to log in.`). Currently the default command prints `Type ${magenta(`${brand} --help`)} to view common commands.` so I think magenta is a good candidate for this.

  1. Document all the theme methods in the docs

Currently the docs don't document the following theme methods:

  • highlight
  • line

I especially wanted to use the same consistent highlight color as the default commands, and had been using cyan until I was snooping through the source and discovered the highlight method. I think it would be useful to expose all of them.

@kathawala
Copy link
Contributor

Just submitted a PR which does what I think you want (instead of command, I just named it highlight). Hope it helps 👍

@blake-mealey
Copy link
Author

@kathawala not quite what I was after. I can already access the highlight color from the print.colors object. I would like a new color called command which is an alias for magenta. I also don't want it to print the full line that color, so I'd still want it to be part of the colors object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants