Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portuguese Language #3

Open
HenriqueChen opened this issue Oct 29, 2021 · 6 comments
Open

Portuguese Language #3

HenriqueChen opened this issue Oct 29, 2021 · 6 comments
Assignees
Labels
language This issue represents a language that is in progress released

Comments

@HenriqueChen
Copy link
Contributor

What language do you wish to contribute?
Portuguese

@HenriqueChen HenriqueChen added the language This issue represents a language that is in progress label Oct 29, 2021
@carmichaelalonso
Copy link
Collaborator

@HenriqueChen Thanks for offering to translate Portuguese! Please let us know if you have any questions. You can ask here, or DM me on the IFC

@HenriqueChen
Copy link
Contributor Author

I just finished the translation, how to make a pull request?

@carmichaelalonso
Copy link
Collaborator

Great, obrigado!

Here is some information on how to do it:

https://www.freecodecamp.org/news/how-to-make-your-first-pull-request-on-github-3/

It will then ask you to sign a CLA before we can merge it. Let me know if you have any questions!

@carmichaelalonso
Copy link
Collaborator

carmichaelalonso commented Nov 1, 2021

Hi @HenriqueChen, thank you again for your contribution. I have imported it into IF:

image

image

image

I have a few comments:

  • We have added Tips and ServerMessages folders with in-game tips and the messages that are shown when you start a session in each server. Are you able to translate this when you get time?

  • For VOAR OFFLINE, is there another way of saying this? We said SOLO in Spanish because it is most similar to "alone". The reason is that "offline" may imply the game can be played without an internet connection.

  • We have added a few more strings to translate for settings. Let me know if you're able to take a look at these:
    3728937

  • I'll add your name in our About page as HenriqueChen, if you would like me to write it differently, please let me know!

Obrigado :)

@HenriqueChen
Copy link
Contributor Author

Hello Cameron, about the "tips" and "server messages", yes i'm able to translate that. i will change the "VOAR OFFLINE" to "VOAR SOLO", i will see the missing strings to correct.

@carmichaelalonso
Copy link
Collaborator

image

Looks great, thanks for the correction!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language This issue represents a language that is in progress released
Projects
None yet
Development

No branches or pull requests

2 participants