From 495a624be68093de1fc5fc6792e21279ef2b1ad5 Mon Sep 17 00:00:00 2001
From: "Rafalko, Maksim" <maks.rafalko@gmail.com>
Date: Mon, 27 May 2024 00:44:13 +0200
Subject: [PATCH] Add tests

---
 app/src/Controller/AstController.php          |  3 +
 app/src/Form/CreateAstRunType.php             |  5 +-
 app/src/Request/CreateAstRunRequest.php       |  2 +-
 .../Controller/AstControllerTest.php          | 89 +++++++++++++++++++
 4 files changed, 94 insertions(+), 5 deletions(-)
 create mode 100644 app/tests/Functional/Controller/AstControllerTest.php

diff --git a/app/src/Controller/AstController.php b/app/src/Controller/AstController.php
index 40431be..0bb6d58 100644
--- a/app/src/Controller/AstController.php
+++ b/app/src/Controller/AstController.php
@@ -59,6 +59,7 @@
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Routing\Attribute\Route;
+use Webmozart\Assert\Assert;
 
 class AstController extends AbstractController
 {
@@ -92,6 +93,8 @@ public function createExample(Request $request, EntityManagerInterface $em): Res
         $form->handleRequest($request);
 
         if ($form->isSubmitted() && $form->isValid()) {
+            Assert::notNull($createAstRunRequest->code);
+
             $existingAstRun = $this->astRunRepository->findContentByHash(
                 AstRun::hashInput($createAstRunRequest->code)
             );
diff --git a/app/src/Form/CreateAstRunType.php b/app/src/Form/CreateAstRunType.php
index 6cc8c6f..fc78e00 100644
--- a/app/src/Form/CreateAstRunType.php
+++ b/app/src/Form/CreateAstRunType.php
@@ -45,10 +45,7 @@
 
 class CreateAstRunType extends AbstractType
 {
-    /**
-     * @var UrlGeneratorInterface
-     */
-    private $urlGenerator;
+    private UrlGeneratorInterface $urlGenerator;
 
     public function __construct(UrlGeneratorInterface $urlGenerator)
     {
diff --git a/app/src/Request/CreateAstRunRequest.php b/app/src/Request/CreateAstRunRequest.php
index cf6895a..0c8f1c3 100644
--- a/app/src/Request/CreateAstRunRequest.php
+++ b/app/src/Request/CreateAstRunRequest.php
@@ -43,7 +43,7 @@ class CreateAstRunRequest
 {
     #[AppAssert\ValidPhpCode]
     #[Assert\NotBlank]
-    public string $code;
+    public ?string $code = null;
 
     public static function fromEntity(AstRun $astRun): self
     {
diff --git a/app/tests/Functional/Controller/AstControllerTest.php b/app/tests/Functional/Controller/AstControllerTest.php
new file mode 100644
index 0000000..5cc236c
--- /dev/null
+++ b/app/tests/Functional/Controller/AstControllerTest.php
@@ -0,0 +1,89 @@
+<?php
+/**
+ * This code is licensed under the BSD 3-Clause License.
+ *
+ * Copyright (c) 2017, Maks Rafalko
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *
+ * * Redistributions of source code must retain the above copyright notice, this
+ *   list of conditions and the following disclaimer.
+ *
+ * * Redistributions in binary form must reproduce the above copyright notice,
+ *   this list of conditions and the following disclaimer in the documentation
+ *   and/or other materials provided with the distribution.
+ *
+ * * Neither the name of the copyright holder nor the names of its
+ *   contributors may be used to endorse or promote products derived from
+ *   this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+ * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+ * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+ * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+ * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+declare(strict_types=1);
+
+namespace App\Tests\Functional\Controller;
+
+use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
+
+class AstControllerTest extends WebTestCase
+{
+    public function test_it_creates_an_ast_run(): void
+    {
+        $client = static::createClient();
+        $client->catchExceptions(false);
+
+        $client->request('GET', '/ast');
+        static::assertSame(200, $client->getResponse()->getStatusCode());
+
+        $client->submitForm('create_ast_run[buildAst]', [
+            'create_ast_run[code]' => 'code',
+        ]);
+
+        static::assertSame(302, $client->getResponse()->getStatusCode());
+        static::assertStringNotContainsString('This value should not be blank', (string) $client->getResponse()->getContent());
+    }
+
+    public function test_it_fails_with_when_code_is_blank(): void
+    {
+        $client = static::createClient();
+        $client->followRedirects();
+        $client->catchExceptions(false);
+
+        $client->request('GET', '/ast');
+
+        $client->submitForm('create_ast_run[buildAst]', [
+            'create_ast_run[code]' => '',
+        ]);
+
+        static::assertSame(200, $client->getResponse()->getStatusCode());
+        static::assertStringContainsString('This value should not be blank', (string) $client->getResponse()->getContent());
+    }
+
+    public function test_it_fails_with_when_code_is_invalid(): void
+    {
+        $client = static::createClient();
+        $client->followRedirects();
+        $client->catchExceptions(false);
+
+        $client->request('GET', '/ast');
+
+        $client->submitForm('create_ast_run[buildAst]', [
+            'create_ast_run[code]' => '<?php $a ==== $b;',
+        ]);
+
+        static::assertSame(200, $client->getResponse()->getStatusCode());
+        static::assertStringContainsString('This is not a valid PHP code. Errors: Syntax error, unexpected', (string) $client->getResponse()->getContent());
+    }
+}