[v2] Partial reload incorrectly evaluates props not included in response (optional & lazy)

[MarcEspiard]

Hi,

Testing v2 beta1 released today.

Just testing deferred props and noticed that my shared props were evaluated during the loading of the deferred props (partial load), even though all my shared props are in the Optional form and shouldn't be evaluated during a partial load.

"shared_list" => fn() => ...

I've tracked the issue to the resolveProperties function in Response:

inertia-laravel/src/Response.php

Lines 134 to 159 in 141256b

	public function resolveProperties(Request $request, array $props): array
	{
	$isPartial = $this->isPartial($request);
	if (! $isPartial) {
	$props = array_filter($this->props, static function ($prop) {
	return ! ($prop instanceof IgnoreFirstLoad);
	});
	}
	$props = $this->resolveArrayableProperties($props, $request);
	if ($isPartial && $request->hasHeader(Header::PARTIAL_ONLY)) {
	$props = $this->resolveOnly($request, $props);
	}
	if ($isPartial && $request->hasHeader(Header::PARTIAL_EXCEPT)) {
	$props = $this->resolveExcept($request, $props);
	}
	$props = $this->resolveAlways($props);
	$props = $this->resolvePropertyInstances($props, $request);
	return $props;
	}

Calling

inertia-laravel/src/Response.php

Line 144 in 141256b

$props = $this->resolveArrayableProperties($props, $request);

resolves all props, no matter if they are supposed to be included in the response.

Moving $props = $this->resolveArrayableProperties($props, $request); below resolveExcept solves the issue as the props have been filtered at the point.

I don't know the potential ramifications of moving this line of code since this is a brand new refactor, but if it's OK with you I'm happy to submit a PR for the fix. Just let me know

[wizzymore]

I just came here to report the same issue.

Instead of not running the closure on partial realods, even if you use only: [key_not_included_here] or except: [key_included_here] it will correctly NOT appear in the response, but it will be evaluated and all the code inside the closure will run.