Blocking Calls on versionTransactions #2
Comments
ghost
assigned 
|
Will really need to be handled along with #273 . |
signature, `dbName` for force-closing databases of a particular name
- Add missing API: `versionchange` and `blocked` events (currently assumes
single process); addresses indexeddbshim#2
- Fix: Close connection on abort (setting closed flag)
- Fix: Have `deleteDatabase` empty relevant `connections` (relevant
for `__forceClose` as well as `open`)
- Refactoring: Rename `transformW3CStack.js` to `transformV8Stack.js`
- Refactoring: Move excluded files into good-bad files file
- Testing (W3C Old): Partly update `TransactionBehavior.js` tests to
ensure `objectStoreNames` are compared as arrays
- Testing (Mocha): For now, make exception for Chrome as with other
browsers to `window.onerror` tests in `IDBTransaction/events-spec.js`
but keep note in testing list
- Testing (mock): Fix for `blocked` event's expected `newVersion` (submitted
fix as <kristofdegrave/indexedDBmock#2>)
IndexedDB Test counts:
323 normal files (including 1 domstringlist file):
315 are all good, 3 have some that are bad,
5 have some that time out and 3 have some that do not run
7 excluded files (uncaught exceptions during testing):
`bindings-inject-key.js`,
`keypath-exceptions.js`,
'event-dispatch-active-flag.js',
'fire-error-event-exception.js',
'fire-success-event-exception.js',
'fire-upgradeneeded-event-exception.js'
'upgrade-transaction-deactivation-timing.js'
Current IndexedDB (and domstringlist) test statuses (vmTimeout = 40000):
'Pass': 1168, (including 4 domstringlist tests but avoiding exclusions)
'Fail': 6,
'Timeout': 5,
'Not Run': 3,
'Total tests': 1182 (including 4 domstringlist tests but avoiding exclusions)
|
For single processes, this issue is now fixed in However, I think we should keep this issue open as blocked/versionchange events still don't work if someone is running multiple tabs or processes In the browser, this fix might be implemented via a shared worker but if a browser supports that, it might not be in much need of an IndexedDB shim. In Node, this fix might be implemented via a shared process or such (ideally via a SharedWorker polyfill which we need for testing anyways). As mentioned, #273 is another issue relating to multiple processes which ought to be addressed. |
|
However, I'll relabel the issue as environment-specific since it probably isn't really practical to polyfill for the browser but it could be and ideally will be done in Node. |
Version transactions are not blocking, they should not allow any other transactions when version transactions are in progress
The text was updated successfully, but these errors were encountered: