Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Jassub for previews #26

Open
incidentist opened this issue Dec 31, 2023 · 1 comment
Open

Switch to Jassub for previews #26

incidentist opened this issue Dec 31, 2023 · 1 comment

Comments

@incidentist
Copy link
Owner

Jassub seems better for subtitle previews. It does feel like the current version is a fraction of a second off from what the end result video ends up being.
@incidentist
Copy link
Owner Author

I think I'm mostly done with this. Jassub has a different API for some reason: setCurrentTime takes a bunch of extra arguments, and setIsPaused takes fewer arguments. But for the most part, it's a drop-in replacement. I will have to verify that the libass-wasm is actually off by a little bit, but even if it's not, this sounds more performant, easier to configure, and smaller than libass-wasm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@incidentist