Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Logging and exmplary logging checkpoints #53

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

hunnguye
Copy link

@hunnguye hunnguye commented Aug 14, 2024

What's in the PR
Added basic logging capabilities. Resolves #52

How to test manually

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@serwarde
Copy link
Collaborator

Thank you for the work, it's a useful issue! I'll take a look at it

@serwarde serwarde self-requested a review August 15, 2024 13:24
@serwarde serwarde added the ⭐️ Enhancement New feature or request label Aug 15, 2024
@serwarde
Copy link
Collaborator

The implementation looks good, but could you expand it to the lead view too please?
And there is a conflict after the last merge on the main branch that needs to be solved too

@hunnguye
Copy link
Author

Hey,
I resolved the merge conflict and updated the approach to use a YAML file for logger configuration

Given the complexity of the project I believe it's rather a better approach, if logs are successively implemented as the development progresses. Realistically, I don't think I am able to get familiar with the codebase in an appropriate time frame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐️ Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introducing Logging capabilities
2 participants