Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowed values when working with integers #55

Open
stijnvanhoey opened this issue Aug 23, 2018 · 0 comments
Open

allowed values when working with integers #55

stijnvanhoey opened this issue Aug 23, 2018 · 0 comments

Comments

@stijnvanhoey
Copy link
Collaborator

Allowed values compares strings, but in the yaml-specification users can actually provide integer values as well, e.g.

uncertainty: 
    allowed: 3650

The yaml-parser will interpret this as a dictionary with an integer value leading to issues on the validation, whereas

uncertainty: 
    allowed: '3650'

will compare the string values as such.

Either we interpret all allowed specifications as a string (nevertheless the type) or we could argue to the user that for numbers, the following specs are more appropriate:

uncertainty: 
    numberformat: x
    min: 3650
    max: 3650

@peterdesmet ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant