Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node to "known" check fields #63

Open
smoyer64 opened this issue Aug 7, 2019 · 0 comments
Open

Add node to "known" check fields #63

smoyer64 opened this issue Aug 7, 2019 · 0 comments

Comments

@smoyer64
Copy link

smoyer64 commented Aug 7, 2019

In #58 it's noted that node is used in the example without being defined in the specification. While I agree that the functionality requested in #58 may be important, I'd suggest that node or some other unique identifier is needed.

The specification states:

Since each sub-component may be backed by several nodes with varying health statuses, these keys point to arrays of objects. In case of a single-node sub-component (or if presence of nodes is not relevant), a single-element array SHOULD be used as the value, for consistency.

Since an array SHOULD be used, I feel like this specification should also identify the field within the check that identifies which instance of the component the enclosed component represents. The word node or nodeId make sense for clustered operation but perhaps instance or instanceId would be more generic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant