Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Availability of cwltool #4

Open
AsierGonzalez opened this issue Apr 13, 2021 · 0 comments
Open

Availability of cwltool #4

AsierGonzalez opened this issue Apr 13, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@AsierGonzalez
Copy link
Collaborator

AsierGonzalez commented Apr 13, 2021

The VRE_RUNNER bash script does two things that seem contradictory:

  1. Checks if cwltool is available: type -a "$prog" >/dev/null in line 17
  2. Activates virtual environment: source "$BASEDIR"/venv/bin/activate in line 26

These two steps are contradictory because for cwltool to be available it has to be installed globally or the virtual environment has to be activated first. I don't think we want cwltool to be installed globally so I would suggest that we revamp the script so that it first activates de environment and it then checks whether cwltool is installed.

@lrodrin lrodrin added the enhancement New feature or request label Sep 13, 2021
@lrodrin lrodrin removed their assignment Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants