Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Review Attestor #120

Open
colek42 opened this issue Jan 26, 2022 · 0 comments
Open

Code Review Attestor #120

colek42 opened this issue Jan 26, 2022 · 0 comments
Labels
needs triage Issues to triage

Comments

@colek42
Copy link
Member

colek42 commented Jan 26, 2022

We need to think about the API for this attestor. Since the scope is pretty specific and we may want a specific CLI to guide the user we may want to add a new command "review".

Proposed API:
witness review -k key.pem --sec-audit pass -m "LGTM"

@TomHennen proposed this shape:

{
  "_type": "https://in-toto.io/Statement/v0.1",
  // Assuming the release is a file and we can just hash it.
  "subject": [{"name": "_", "digest": {"sha256": "5678..."}}],
  "predicateType": "https://slsa.dev/review/versionedRelease/v0.1",
  "predicate": {
    "reviews": [
      "code-review", // Indicates all the code in the release was reviewed.
      "sec-audit", // indicates all the code in the release was security audited
    ]
    "attestor": { "id": "mailto:[email protected]" },
  }
}

ref: in-toto/attestation#77

@jkjell jkjell added the needs triage Issues to triage label Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Issues to triage
Projects
None yet
Development

No branches or pull requests

2 participants