Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support v1.0 SLSA provenance format #197

Closed
asraa opened this issue Jan 19, 2023 · 0 comments · Fixed by #221
Closed

Support v1.0 SLSA provenance format #197

asraa opened this issue Jan 19, 2023 · 0 comments · Fixed by #221
Labels
enhancement New feature or request

Comments

@asraa
Copy link
Contributor

asraa commented Jan 19, 2023

Description of the feature request:

Support v1.0 SLSA provenance, as defined in a draft here: slsa-framework/slsa#525

This will be merged soon, and so I can help to start a PR defining the struct, so long as the type is defined with a ?draft URI for now. (Or we can wait to merge it).

One item to consider here that I've always wondered is should we be using generated Go code against the protobuf message defining the predicate? This would mean that the oneof support comes out of the box. On the other hand, there's some overhead of bringing in the proto runtime dependencies and complexity.

The oneof could also be handled by an interface, but this is also a little bit of overhead.

cc @MarkLodato @rbehjati @laurentsimon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants