fix: genesis data validation (#259)

* fix: genesis data validation

* fix: stateful validation of genesis block

* fix(comment)

* fix(dogfood): reject genesis duplicate assets

* feat(delegation): query assoc staker for operator

* fix: respond to AI comments

Author: MaxMustermann2

app/app.go

@@ -547,7 +547,7 @@ func NewExocoreApp(
 
 	// asset and client chain registry.
 	app.AssetsKeeper = assetsKeeper.NewKeeper(
-		keys[assetsTypes.StoreKey], appCodec, &app.OracleKeeper,
+		keys[assetsTypes.StoreKey], appCodec, &app.OracleKeeper, app.AccountKeeper,
 		app.BankKeeper, &app.DelegationKeeper, authAddrString,
 	)
 

proto/exocore/delegation/v1/query.proto

@@ -114,6 +114,18 @@ message QueryAssociatedOperatorByStakerResponse {
   string operator = 1;
 }
 
+// QueryAssociatedStakersByOperatorReq is the request to obtain the associated stakers of the specified operator
+message QueryAssociatedStakersByOperatorReq {
+  // operator is the operator address for which the query is made.
+  string operator = 1;
+}
+
+// QueryAssociatedStakersByOperatorResponse is the response to QueryAssociatedStakersByOperatorReq
+message QueryAssociatedStakersByOperatorResponse {
+  // stakers is the returned stakers associated to the specified operator
+  repeated string stakers = 1;
+}
+
 // Query is the service API for the delegation module.
 service Query {
   // DelegationInfo queries the delegation information for {stakerID, assetID}.
@@ -153,4 +165,11 @@ service Query {
     option (cosmos.query.v1.module_query_safe) = true;
     option (google.api.http).get = "/exocore/delegation/v1/QueryAssociatedOperatorByStaker";
   }
+
+  // QueryAssociatedStakersByOperator queries the associated stakers for the specified operator
+  rpc QueryAssociatedStakersByOperator(QueryAssociatedStakersByOperatorReq)
+      returns (QueryAssociatedStakersByOperatorResponse) {
+    option (cosmos.query.v1.module_query_safe) = true;
+    option (google.api.http).get = "/exocore/delegation/v1/QueryAssociatedStakersByOperator/{operator}";
+  }
 }

x/assets/keeper/genesis.go

@@ -2,7 +2,9 @@ package keeper
 
 import (
 	errorsmod "cosmossdk.io/errors"
+	"github.com/ExocoreNetwork/exocore/utils"
 	"github.com/ExocoreNetwork/exocore/x/assets/types"
+	delegationtypes "github.com/ExocoreNetwork/exocore/x/delegation/types"
 	sdk "github.com/cosmos/cosmos-sdk/types"
 )
 
@@ -46,6 +48,7 @@ func (k Keeper) InitGenesis(ctx sdk.Context, data *types.GenesisState) {
 		}
 	}
 
+	exoDelegation := sdk.ZeroInt()
 	for _, assets := range data.OperatorAssets {
 		for _, assetInfo := range assets.AssetsState {
 			// #nosec G703 // already validated
@@ -55,8 +58,26 @@ func (k Keeper) InitGenesis(ctx sdk.Context, data *types.GenesisState) {
 			if err != nil {
 				panic(errorsmod.Wrap(err, "failed to set operator asset info"))
 			}
+			if assetInfo.AssetID == types.ExocoreAssetID {
+				exoDelegation = exoDelegation.Add(assetInfo.Info.TotalAmount)
+			}
 		}
 	}
+
+	// check that this exoDelegation amount is reflected in x/bank
+	address := k.ak.GetModuleAccount(ctx, delegationtypes.DelegatedPoolName).GetAddress()
+	balance := k.bk.GetBalance(ctx, address, utils.BaseDenom)
+	// slashing is lazily applied at the time of withdrawal. it means that
+	// exoDelegation may have been slashed, but balance will never be slashed.
+	// it implies that exoDelegation should be less than or equal to balance.
+	// or conversely, if exoDelegation is greater than balance, we have a problem.
+	if exoDelegation.GT(balance.Amount) {
+		panic(errorsmod.Wrapf(
+			types.ErrInvalidGenesisData,
+			"delegated pool account balance is too low, exoDelegation: %s, balance: %s",
+			exoDelegation, balance.Amount,
+		).Error())
+	}
 }
 
 // ExportGenesis returns the module's exported genesis.

x/assets/keeper/keeper.go

@@ -15,6 +15,7 @@ type Keeper struct {
 	storeKey storetypes.StoreKey
 	cdc      codec.BinaryCodec
 	assetstype.OracleKeeper
+	ak        assetstype.AccountKeeper
 	bk        assetstype.BankKeeper
 	dk        delegationKeeper
 	authority string
@@ -24,6 +25,7 @@ func NewKeeper(
 	storeKey storetypes.StoreKey,
 	cdc codec.BinaryCodec,
 	oracleKeeper assetstype.OracleKeeper,
+	ak assetstype.AccountKeeper,
 	bk assetstype.BankKeeper,
 	dk delegationKeeper,
 	authority string,
@@ -36,6 +38,7 @@ func NewKeeper(
 		storeKey:     storeKey,
 		cdc:          cdc,
 		OracleKeeper: oracleKeeper,
+		ak:           ak,
 		bk:           bk,
 		dk:           dk,
 		authority:    authority,

x/assets/types/expected_keepers.go

@@ -4,6 +4,7 @@ import (
 	sdkmath "cosmossdk.io/math"
 	oracletypes "github.com/ExocoreNetwork/exocore/x/oracle/types"
 	sdk "github.com/cosmos/cosmos-sdk/types"
+	authtypes "github.com/cosmos/cosmos-sdk/x/auth/types"
 )
 
 type OracleKeeper interface {
@@ -15,3 +16,7 @@ type OracleKeeper interface {
 type BankKeeper interface {
 	GetBalance(ctx sdk.Context, addr sdk.AccAddress, denom string) sdk.Coin
 }
+
+type AccountKeeper interface {
+	GetModuleAccount(ctx sdk.Context, moduleName string) authtypes.ModuleAccountI
+}

x/assets/types/genesis.go

@@ -7,7 +7,6 @@ import (
 	"cosmossdk.io/math"
 	"github.com/ExocoreNetwork/exocore/utils"
 	sdk "github.com/cosmos/cosmos-sdk/types"
-	"github.com/ethereum/go-ethereum/common"
 )
 
 // NewGenesis returns a new genesis state with the given inputs.
@@ -86,15 +85,6 @@ func (gs GenesisState) ValidateTokens(lzIDs map[uint64]struct{}) (map[string]mat
 				info.AssetBasicInfo.Name, address,
 			)
 		}
-		// build for 0x addresses only.
-		// TODO: consider removing this check for non-EVM client chains.
-		if !common.IsHexAddress(address) {
-			return errorsmod.Wrapf(
-				ErrInvalidGenesisData,
-				"not hex address for token %s, address: %s",
-				info.AssetBasicInfo.Name, address,
-			)
-		}
 
 		// ensure there are no deposits for this asset already (since they are handled in the
 		// genesis exec). while it is possible to remove this field entirely (and assume 0),
@@ -255,8 +245,10 @@ func (gs GenesisState) ValidateOperatorAssets(tokensTotalStaking map[string]math
 					assets.Operator, asset.AssetID,
 				)
 			}
-			// the sum amount of operators shouldn't be greater than the total staking amount of this asset
-			if asset.Info.TotalAmount.Add(asset.Info.PendingUndelegationAmount).GT(totalStaking) {
+			// the sum amount of operators shouldn't be greater than the total staking amount of this asset.
+			// however, this line should not apply for the native asset, since that is handled by x/bank.
+			if asset.Info.TotalAmount.Add(asset.Info.PendingUndelegationAmount).GT(totalStaking) &&
+				asset.AssetID != ExocoreAssetID {
 				return errorsmod.Wrapf(
 					ErrInvalidGenesisData,
 					"operator's sum amount exceeds the total staking amount for %s: %+v",

x/delegation/client/cli/query.go

@@ -32,6 +32,7 @@ func GetQueryCmd() *cobra.Command {
 		QueryUndelegationsByHeight(),
 		QueryUndelegationHoldCount(),
 		QueryAssociatedOperatorByStaker(),
+		QueryAssociatedStakersByOperator(),
 	)
 	return cmd
 }
@@ -244,3 +245,35 @@ func QueryAssociatedOperatorByStaker() *cobra.Command {
 	flags.AddQueryFlagsToCmd(cmd)
 	return cmd
 }
+
+func QueryAssociatedStakersByOperator() *cobra.Command {
+	cmd := &cobra.Command{
+		Use:   "QueryAssociatedStakersByOperator <operatorAddr>",
+		Short: "Get the associated stakers for the specified operator",
+		Long:  "Get the associated stakers for the specified operator",
+		Args:  cobra.ExactArgs(1),
+		RunE: func(cmd *cobra.Command, args []string) error {
+			clientCtx, err := client.GetClientQueryContext(cmd)
+			if err != nil {
+				return err
+			}
+
+			accAddr, err := sdk.AccAddressFromBech32(args[0])
+			if err != nil {
+				return errorsmod.Wrap(types.ErrInvalidCliCmdArg, err.Error())
+			}
+			queryClient := delegationtype.NewQueryClient(clientCtx)
+			req := &delegationtype.QueryAssociatedStakersByOperatorReq{
+				Operator: accAddr.String(),
+			}
+			res, err := queryClient.QueryAssociatedStakersByOperator(context.Background(), req)
+			if err != nil {
+				return err
+			}
+			return clientCtx.PrintProto(res)
+		},
+	}
+
+	flags.AddQueryFlagsToCmd(cmd)
+	return cmd
+}

x/delegation/keeper/delegation_state.go

@@ -373,6 +373,27 @@ func (k *Keeper) GetAssociatedOperator(ctx sdk.Context, stakerID string) (string
 	return "", nil
 }
 
+func (k *Keeper) GetAssociatedStakers(ctx sdk.Context, operator string) ([]string, error) {
+	if _, err := sdk.AccAddressFromBech32(operator); err != nil {
+		return nil, delegationtype.ErrOperatorAddrIsNotAccAddr
+	}
+	store := prefix.NewStore(ctx.KVStore(k.storeKey), delegationtype.KeyPrefixAssociatedOperatorByStaker)
+	iterator := sdk.KVStorePrefixIterator(store, []byte{})
+	defer iterator.Close()
+
+	// assuming that we support 5 client chains, this is a reasonable capacity.
+	// we can of course support more or less than that, but this is a good
+	// starting point.
+	// ideally, we should have a reverse lookup stored for this.
+	ret := make([]string, 0, 5)
+	for ; iterator.Valid(); iterator.Next() {
+		if string(iterator.Value()) == operator {
+			ret = append(ret, string(iterator.Key()))
+		}
+	}
+	return ret, nil
+}
+
 func (k *Keeper) GetAllAssociations(ctx sdk.Context) ([]delegationtype.StakerToOperator, error) {
 	store := prefix.NewStore(ctx.KVStore(k.storeKey), delegationtype.KeyPrefixAssociatedOperatorByStaker)
 	iterator := sdk.KVStorePrefixIterator(store, []byte{})

x/delegation/keeper/grpc_query.go

@@ -57,3 +57,14 @@ func (k Keeper) QueryAssociatedOperatorByStaker(ctx context.Context, req *delega
 		Operator: operator,
 	}, nil
 }
+
+func (k Keeper) QueryAssociatedStakersByOperator(ctx context.Context, req *delegationtype.QueryAssociatedStakersByOperatorReq) (*delegationtype.QueryAssociatedStakersByOperatorResponse, error) {
+	c := sdk.UnwrapSDKContext(ctx)
+	stakers, err := k.GetAssociatedStakers(c, req.Operator)
+	if err != nil {
+		return nil, err
+	}
+	return &delegationtype.QueryAssociatedStakersByOperatorResponse{
+		Stakers: stakers,
+	}, nil
+}