-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[import/order] Breaking change in v2.27 #2722
Comments
I agree that it was an unintentional change, and also that the one that’s right in 2.26 is the right one. (i think the change you’re referencing was #2396) |
yep |
Any news on this? |
No, not yet, but it'd be great to get a PR up to fix it. |
Just revert #2396 |
@7iomka it may not be that simple; there may be some fixes in it that we'd need to keep. |
This is still broken in 2.28. We're hitting it in microsoft/accessibility-insights-web#6846. Here's a quick unit test to use as a reference:
|
In version 2.27.0 it was introduced a new strategy which splits the imports paths in segments and compares them independently.
However, this leads to different results for the same inputs in some cases, for example:
this is the "right" order as by v2.26 because:
but in v2.27 it is reported as error because:
I don't know if the current behavior is the right one, but it is definitely a breaking change
The text was updated successfully, but these errors were encountered: