From e7392f5fed18258d0163eee8db98fade6600c202 Mon Sep 17 00:00:00 2001 From: Gareth Jones Date: Mon, 11 Nov 2024 10:10:08 +1300 Subject: [PATCH] ci: move `types` job to pretest workflow --- .github/workflows/node-4+.yml | 13 ------------- .github/workflows/node-pretest.yml | 13 +++++++++++++ 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/.github/workflows/node-4+.yml b/.github/workflows/node-4+.yml index 1d7488771..323c2ad54 100644 --- a/.github/workflows/node-4+.yml +++ b/.github/workflows/node-4+.yml @@ -10,19 +10,6 @@ permissions: contents: read jobs: - types: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v4 - - uses: ljharb/actions/node/install@main - name: 'npm install' - with: - skip-ls-check: true - # for some reason we've got to force typescript to install here - # even though the npm script has `typescript@latest` - - run: npm i --force typescript@latest - - run: npm run test-types - matrix: runs-on: ubuntu-latest outputs: diff --git a/.github/workflows/node-pretest.yml b/.github/workflows/node-pretest.yml index f8db36de5..e25b00e49 100644 --- a/.github/workflows/node-pretest.yml +++ b/.github/workflows/node-pretest.yml @@ -18,6 +18,19 @@ jobs: # skip-ls-check: true # - run: npm run pretest + types: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - uses: ljharb/actions/node/install@main + name: 'npm install' + with: + skip-ls-check: true + # for some reason we've got to force typescript to install here + # even though the npm script has `typescript@latest` + - run: npm i --force typescript@latest + - run: npm run test-types + posttest: runs-on: ubuntu-latest