IsClientAllowed in RedisInformationMiddleware

[half-naan]

When using app.UseRedisInformation we are required to send an empty array of Allowed IP's even when we just want to use lambda function for IsClientAllowed in RedisInformationMiddleware to access /redis/connectionInfo and /redis/info.

app.UseRedisInformation(options =>
            {
                options.AllowedIPs = new System.Net.IPAddress[0];//required
                options.AllowFunction = (HttpContext ctx) =>
                {
                    // My custom logic
                    if (ctx.User.Identity.IsAuthenticated && ctx.User.IsInRole("Admin"))
                        return true;
                    return false;
                };
            });

Ideally, we should be able to skip the IP as needed.

app.UseRedisInformation(options =>
            {
                options.AllowFunction = (HttpContext ctx) =>
                {
                    // My custom logic
                    if (ctx.User.Identity.IsAuthenticated && ctx.User.IsInRole("Admin"))
                        return true;
                    return false;
                };
            });

Right now the source code is written that if there is no IP list provided it completely ignores the lambda function. Perhaps we can break IsClientAllowed in RedisInformationMiddleware to 3 different scenarios?

1). Both IP and lambda function are provided

2). Only IP list check

3). Only lambda function check

[LeaFrock]

It's a break change but makes some sense.

Do you think it's a chance to change it when we're preparing for .NET 9 release? @imperugo

    private bool IsClientAllowed(HttpContext context)
    {
        // Make `AllowFunction` higher priority so that users can use `AllowedIPs` in their own logic.
        var allowFunc = options.AllowFunction;
        if (allowFunc != null)
            return allowFunc.Invoke(context);

        var allowIPs = options.AllowedIPs;
        // TODO: The IP isn't real in a reverse-proxy environment. Maybe we can improve it and handle more simple scenarios.
        if (allowIPs is { Length: > 0 })
            return Array.Exists(allowIPs, p => p.Equals(context.Connection.RemoteIpAddress));

        return false; // If both are null, return T or F?
    }

[imperugo]

@LeaFrock yes is something that we can add to the next major release.
Let's put it into your branch, but we have to remember to update documentation (maybe with a specific version for migration from version X to Y)