Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Daily Quests]: Multiple Issues with Daily Quest Handling/Quest Title Error #34

Closed
3 tasks done
imnaiyar opened this issue Jul 14, 2024 · 0 comments · Fixed by #39
Closed
3 tasks done

[Daily Quests]: Multiple Issues with Daily Quest Handling/Quest Title Error #34

imnaiyar opened this issue Jul 14, 2024 · 0 comments · Fixed by #39
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@imnaiyar
Copy link
Owner

imnaiyar commented Jul 14, 2024

Describe the bug

  • Credits for quest guides are displayed as undefined
  • Sometimes when uodating daily quests, titles aren't properly captured (or not captured at all). Looks like we may need a better regex.

To Reproduce
Steps to reproduce the behavior:

  1. Run the command /daily-quests
  2. See credits displayed as undefined

Expected behavior
Credit to be displayed properly and correctly

Screenshots

Screenshot_20240714_150558_Discord

Additional context
Seems to be that the regex to capture credits/title here

const credit = creditRegex.exec(message.content)?.[0].slice(3);
is not working properly (probably because the logic is wrong)

  • fix credit regex
  • fix title regex
  • better handling for updating quests
@imnaiyar imnaiyar changed the title [Daily Quests]: Credits are displayed as undefined for quest guided [Daily Quests]: Credits are displayed as undefined for quest guides Jul 14, 2024
@imnaiyar imnaiyar self-assigned this Jul 14, 2024
@imnaiyar imnaiyar added bug Something isn't working good first issue Good for newcomers labels Jul 14, 2024
@imnaiyar imnaiyar changed the title [Daily Quests]: Credits are displayed as undefined for quest guides [Daily Quests]: bunch of issues with daily quest commands/handling Jul 16, 2024
@imnaiyar imnaiyar pinned this issue Jul 16, 2024
@imnaiyar imnaiyar changed the title [Daily Quests]: bunch of issues with daily quest commands/handling [Daily Quests]: Multiple Issues with Daily Quest Handling/Quest Title Error Jul 23, 2024
@imnaiyar imnaiyar unpinned this issue Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant