Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ways to clean up C string literals before writing output? #22

Open
anp opened this issue Aug 24, 2018 · 1 comment
Open

Ways to clean up C string literals before writing output? #22

anp opened this issue Aug 24, 2018 · 1 comment
Assignees
Labels
readability Generated code is hard to read and can be simplified

Comments

@anp
Copy link

anp commented Aug 24, 2018

This is pretty hard to parse even once you get used to it: b"contents\x00" as *const u8 as *const c_char. One way to reduce the noise while remaining correct would be to rely on a crate that lets you declare a C string literal like cstr-macro.

@rinon
Copy link
Contributor

rinon commented Oct 3, 2019

Going through and triaging old issues. This has been largely taken care of by refactoring passes that clean up the resulting rust code. I'll dig up some details and examples.

@rinon rinon self-assigned this Oct 3, 2019
@rinon rinon added the readability Generated code is hard to read and can be simplified label Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
readability Generated code is hard to read and can be simplified
Projects
None yet
Development

No branches or pull requests

2 participants