-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging person order is the opposite of expected #8335
Comments
On mine I can select 1 person and then another and select what way to merge. The arrows between them. Pressing it swaps locations of who mergers into who. (I just notice that option) |
generalises #6382 a bit of a pain to fix tho because selecting people to merge can stack multiple people on the source side of the merge operation, which is more efficient but unintuitive enough to where nobody will think to do it |
To work around this issue, you can edit the name of the "merge source" (victim) to the name of the "merge destination" (winner), prompting a dialog that you then need to confirm. This works like a charm (and I didn't even know about the "Merge people" options in the "..." menus). |
I don't see how merging multiple people (named or not) into one is a common use case. I think a common scenario is to merge a "new" person into its already existing (and likely named) variant. If we only allow merging two people (one into the other), we could easily switch the default order in the "merge people" dialog. This would also fix #6382. |
There seem to be two common use cases:
#12601 solves this by:
This still makes it possible to merge multiple people, even in case (2) as additional people can still be added later as additional merge sources. |
The bug
When selecting to Merge a person, Immich defaults to use the currently selected person as the "master" (profile picture and name). I suggest that this is the opposite of expected behavior. When a user selects to "Merge" a person, I suggest they typically have a known (named) target for the Merge. It would make more sense that the default behavior is to Merge a person into an existing person, as opposed to the current behavior.
The OS that Immich Server is running on
Debian 12
Version of Immich Server
1.100.0
Version of Immich Mobile App
1.100.0
Platform with the issue
Your docker-compose.yml content
N/A
Your .env content
Reproduction steps
1. View a person 2. Click Merge Person 3. the default behavior is to merge the pictures from someone else into this person
Additional information
No response
The text was updated successfully, but these errors were encountered: