Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging person order is the opposite of expected #8335

Closed
1 of 3 tasks
mmomjian opened this issue Mar 28, 2024 · 5 comments · Fixed by #12601
Closed
1 of 3 tasks

Merging person order is the opposite of expected #8335

mmomjian opened this issue Mar 28, 2024 · 5 comments · Fixed by #12601

Comments

@mmomjian
Copy link
Contributor

mmomjian commented Mar 28, 2024

The bug

When selecting to Merge a person, Immich defaults to use the currently selected person as the "master" (profile picture and name). I suggest that this is the opposite of expected behavior. When a user selects to "Merge" a person, I suggest they typically have a known (named) target for the Merge. It would make more sense that the default behavior is to Merge a person into an existing person, as opposed to the current behavior.

The OS that Immich Server is running on

Debian 12

Version of Immich Server

1.100.0

Version of Immich Mobile App

1.100.0

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

N/A

Your .env content

N/A

Reproduction steps

1. View a person
2. Click Merge Person
3. the default behavior is to merge the pictures from someone else into this person

Additional information

No response

@almulder
Copy link

On mine I can select 1 person and then another and select what way to merge. The arrows between them. Pressing it swaps locations of who mergers into who. (I just notice that option)

@pyorot
Copy link
Contributor

pyorot commented Jun 22, 2024

generalises #6382

a bit of a pain to fix tho because selecting people to merge can stack multiple people on the source side of the merge operation, which is more efficient but unintuitive enough to where nobody will think to do it

@C-Otto
Copy link
Contributor

C-Otto commented Aug 13, 2024

To work around this issue, you can edit the name of the "merge source" (victim) to the name of the "merge destination" (winner), prompting a dialog that you then need to confirm. This works like a charm (and I didn't even know about the "Merge people" options in the "..." menus).

@C-Otto
Copy link
Contributor

C-Otto commented Aug 13, 2024

I don't see how merging multiple people (named or not) into one is a common use case. I think a common scenario is to merge a "new" person into its already existing (and likely named) variant.

If we only allow merging two people (one into the other), we could easily switch the default order in the "merge people" dialog. This would also fix #6382.

@jrasm91
Copy link
Contributor

jrasm91 commented Sep 12, 2024

There seem to be two common use cases:

  1. Select a named person, go to the merge page, scroll down and select all duplicates
  2. Scroll through the people page, find a duplicate, go to the merge page, selected a named person

#12601 solves this by:

  • Keeping (1) as the default flow, which implies the original selection is the surviving person in the merge.
  • Automatically swapping when (2) is detected (selected person has no name and first merge candidate has a name)

This still makes it possible to merge multiple people, even in case (2) as additional people can still be added later as additional merge sources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants