Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed uploads are immediately attempted to be imported again #14994

Open
1 of 3 tasks
EscolarProgramming opened this issue Dec 30, 2024 · 1 comment
Open
1 of 3 tasks

Comments

@EscolarProgramming
Copy link

The bug

I think I found the real problem behind #14988 (opening another issue, because I think it's a completely independent problem):

I have deleted the previous image that could not be imported. It was then able to import a few successfully until it encountered the next DJI image. And here's what the reals problem is: When an image fails for the first time, it shows as Failed in the backup screen, but immediately after that it tries to import it again. This means that it basically does it correctly first (realizes that it cannot import it and reports it as an error), but then does not skip it, but tries to import it again.

It seems that it only notices that it cannot import it on the first import attempt, but not on all subsequent attempts. Because no matter how many times I cancel the backup and close and reopen the app, the next time I start the backup it tries to import the image again and hangs between 5% and 25% (without marking it as failed).

It would be correct if it marked it as failed each time (or marked it as failed on the first import), and then skipped it in the future instead of hanging on it.

The OS that Immich Server is running on

Alpine Linux v3.20.3

Version of Immich Server

v1.123.0

Version of Immich Mobile App

1.123.0 build.186

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

Installed via https://github.com/alexbelgium/hassio-addons/tree/master/immich

Your .env content

Installed via https://github.com/alexbelgium/hassio-addons/tree/master/immich

Reproduction steps

  1. Have a image which can't be imported (missing file ending in my case)
  2. Try to import it
  3. It can't be imported and blocks the whole import process

Relevant log output

No response

Additional information

No response

@bo0tzz
Copy link
Member

bo0tzz commented Dec 30, 2024

I think this is (in essence) a duplicate of #6173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants