Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background downloader does not take HTTP configuration into account causing asset downloads to fail for certain HTTP configurations #14945

Open
1 of 3 tasks
sdebruyn opened this issue Dec 27, 2024 · 1 comment

Comments

@sdebruyn
Copy link
Contributor

The bug

The user can configure certain HTTP-related features; in my case I came across this issue because I use client certificate validation (mutual TLS / mTLS).

Some features in Immich use the background_downloader package. E.g. when downloading an asset. The HTTP configuration is not passed to this background_downloader package, causing all HTTP requests to fail.

In my case this means I'm unable to download assets.

Code reference

The OS that Immich Server is running on

Cloudflare Tunnel

Version of Immich Server

1.123.0

Version of Immich Mobile App

1.123.0

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

irrelevant

Your .env content

irrelevant

Reproduction steps

  1. Configure Immich server with HTTP proxy or tunnel in front with mTLS
  2. Configure Immich to use mTLS
  3. Download an asset
  4. Result: downloads fail
    ...

Relevant log output

Nothing relevant in the logs

Additional information

No response

@DrieWielRr
Copy link

DrieWielRr commented Jan 1, 2025

I have the exact same problem, didged always-on VPN and started using mTLS a while ago and now the wifey started complaining that she's constantly unable to download pictures out of my shared album.
Testing her claim I was also unable to download cloud-only pictures to my phone (now running 1.123.0, updated from 1.121.0 to see if that fixed the problem but it didnt)..
After switching the app the the local-lan adres downloads worked fine again, setting it back on mTLS settings downloads where unavaileble again with the error "Download failed" and absolutely zero logs about the faillure.

Edit:
Im running mTLS directly on my Fortigate firewall with my own private PKI.

Edit 2:
I know its not related to this issue but just to get it out there once more I'd also really love to see a "dowload selected" option within the app..
Downloading multiple images is a PITA atm..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants