Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit build logs for ko,buildpack #9

Open
imjasonh opened this issue Oct 26, 2020 · 0 comments
Open

Emit build logs for ko,buildpack #9

imjasonh opened this issue Oct 26, 2020 · 0 comments

Comments

@imjasonh
Copy link
Owner

For failed builds, we can emit logs in the error results

For successful builds the response JSON doesn't include error logs. Instead, we can write the build logs to a file and stuff it into a layer in the resulting image at something like /var/log/build.log, then cache and serve that image. This might break reproducibility, if build logs change at all between two builds, but that's already the case based on ko version, go version, buildpack builder version, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant