Dependency on "Resolution" variable is restrictive for .dat file input #109
Closed
PhilipOesterlePekrun
started this conversation in
General
Replies: 2 comments 4 replies
-
@RShaw026 @jacopenji @isteinbrecher Do you have an opinion on this topic? |
Beta Was this translation helpful? Give feedback.
4 replies
-
PR #110 has resolved the topic of this discussion. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
@RShaw026
@NoraHagmeyer
Currently, a lot of the code is built around the "Resolution" variable even when using a .dat file for the height field, so this height field always needs to have dimensions (2^Resolution+1) × (2^Resolution+1) with some integer Resolution. But, it seems to me that the "Resolution" is only really relevant for the random midpoint algorithm to generate random topology. So, I think it would make sense to not restrict the height field in this way in general, and simply base it off N (N × N cells/elements/height-field nodes).
The only issue with this is that the shape factors are given discretely in terms of the Resolution. But, the shape factors aren't fundamentally tied to a resolution and could also be given as functions of N, if I understand correctly. As a first step, the shape factors could simply be interpolated.
Let me know your thoughts on this. I am also restructuring the overall input procedure a bit to make it more straightforward in preparation for Kokkos integration.
Beta Was this translation helpful? Give feedback.
All reactions