You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Cargo features are meant to be additive not mutually exclusive, warp_inner() and all functions that call this function break this additive rule. This could cause unintended behavior as a user won't be able to know which version (parallel vs single-threaded) version was being called due to cargo feature unification. It also means they could never have both the parallel and non-parallel version running in the same application.
To resolve this I suggest duplicating the functions' names to create single-threaded and multi-threaded variants with _parallel() appended. To simplify documentation I suggest the _parallel() versions simply have doc links to the non-parallel versions since duplicating the documentation runs the risk of the two copies of documentation getting out of sync.
The text was updated successfully, but these errors were encountered:
ripytide
changed the title
warp_inner() should be two functions based on rayon featurewarp_inner() and equalize_histogram_mut() should be two functions based on rayon feature
May 21, 2024
Cargo features are meant to be additive not mutually exclusive,
warp_inner()
and all functions that call this function break this additive rule. This could cause unintended behavior as a user won't be able to know which version (parallel vs single-threaded) version was being called due to cargo feature unification. It also means they could never have both the parallel and non-parallel version running in the same application.To resolve this I suggest duplicating the functions' names to create single-threaded and multi-threaded variants with
_parallel()
appended. To simplify documentation I suggest the_parallel()
versions simply have doc links to the non-parallel versions since duplicating the documentation runs the risk of the two copies of documentation getting out of sync.The text was updated successfully, but these errors were encountered: