Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding parameters inconsistently duplicated between Encoder and Info #522

Open
Shnatsel opened this issue Oct 5, 2024 · 1 comment
Open

Comments

@Shnatsel
Copy link
Contributor

Shnatsel commented Oct 5, 2024

As of v0.17.14, some encoding parameters are duplicated between the Info struct and the Encoder struct.

For example, Info has the compression field, but not filter or adaptive_filter. The presence of Info::compression is especially strange because e.g. StreamingDecoder::info() returns an instance of Info but it has no way to know what the compression level originally was, so I have no idea what it's even supposed to return in that case.

@fintelia
Copy link
Contributor

fintelia commented Oct 5, 2024

The Info struct should only hold metadata. We should probably deprecate the compression field and do all tracking of compression settings directly on the Encoder

A followup question is whether we should think about lazy loading of metadata and what the API for that might look like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants