Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The functions and constants under png::chunk should probably be methods and associated constants of png::chunk::ChunkType #402

Open
LikeLakers2 opened this issue Jun 27, 2023 · 0 comments

Comments

@LikeLakers2
Copy link

LikeLakers2 commented Jun 27, 2023

Hi there! I was looking at the png crate, and found everything under the png::chunk module appears to be associated with png::chunk::ChunkType. That is to say, the functions all take a single parameter of type ChunkType, and all the constants are of type ChunkType too.

So I want to suggest that the functions and constants under the png::chunk module be moved to be methods and associated constants of ChunkType. At the least, I don't know of a good reason why they can't be methods and associated constants... If there is a good reason for this, please let me know.

P.S. As an aside, the same issue applies to png::text_metadata::DECOMPRESSION_LIMIT and png::text_metadata::ZTXtChunk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant