Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zlib decompression may exceed allocation limits #286

Open
HeroicKatora opened this issue Feb 19, 2021 · 0 comments
Open

Zlib decompression may exceed allocation limits #286

HeroicKatora opened this issue Feb 19, 2021 · 0 comments
Labels
bug medium

Comments

@HeroicKatora
Copy link
Member

What about doing the actual capping? It seems like finish_compressed_chunks() will happily keep allocating as much as the the zlib stream wants.

Originally posted by @jrmuizel in #285 (comment)

That is, the caller can not control the final size which makes the limits set in Decoder::limits ineffective.
@Shnatsel Shnatsel mentioned this issue Jan 15, 2024
Closed
Shnatsel added a commit to Shnatsel/image that referenced this issue Jan 16, 2024
@Shnatsel
Default to no limits in PNG decoder now that they are actually enforc…
e6e8788 
…ed. This is consistent with other decoders. The limits don't do much right now anyway due to image-rs/image-png#286
@Shnatsel Shnatsel mentioned this issue Jan 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HeroicKatora