Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix high severity issues reported by SonarCloud #2865

Open
iluwatar opened this issue Mar 29, 2024 · 11 comments · Fixed by #2925 · May be fixed by #3061
Open

Fix high severity issues reported by SonarCloud #2865

iluwatar opened this issue Mar 29, 2024 · 11 comments · Fixed by #2925 · May be fixed by #3061
Assignees
@SalmaAzeem @PALASH2201 @haneen-elghawy @mohymohysaleh
Labels
epic: code quality info: good first issue info: help wanted

Comments

@iluwatar
Copy link
Owner

SonarCloud is used for static code analysis. It currently reports 48 high severity issues.

See https://sonarcloud.io/project/issues?impactSeverities=HIGH&resolved=false&id=iluwatar_java-design-patterns

It is possible to run the same analysis on local machine using SonarLint plugin. See instructions at https://github.com/iluwatar/java-design-patterns/wiki/12.-IDE-instructions

Acceptance criteria

  • High severity issues reported by SonarCloud have been fixed
@iluwatar iluwatar converted this from a draft issue Mar 29, 2024
@k1w1dev
Copy link
Contributor

k1w1dev commented Apr 17, 2024

I can start having a go at these, can you assign this to me ?

@iluwatar iluwatar moved this from Todo to In Progress in Java Design Patterns project Apr 17, 2024
@k1w1dev k1w1dev mentioned this issue Apr 19, 2024
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Java Design Patterns project May 4, 2024
@iluwatar
Copy link
Owner Author

iluwatar commented May 4, 2024

Most of the high severity issues fixed by @k1w1dev, but still 18 remain. See https://sonarcloud.io/project/issues?impactSeverities=HIGH&resolved=false&id=iluwatar_java-design-patterns

@iluwatar iluwatar reopened this May 4, 2024
@iluwatar iluwatar moved this from Done to Todo in Java Design Patterns project May 4, 2024
@krishnagjsForGit
Copy link

I can start on these remaining issues.

@iluwatar iluwatar moved this from Todo to In Progress in Java Design Patterns project Jun 15, 2024
@stale Stale
Copy link

stale bot commented Aug 14, 2024

This issue has been automatically marked as stale because it has not had recent activity. The issue will be unassigned if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label Aug 14, 2024
@stale stale bot removed the status: stale issues and pull requests that have not had recent interaction label Sep 22, 2024
@iluwatar iluwatar moved this from In Progress to Todo in Java Design Patterns project Sep 22, 2024
@PALASH2201
Copy link

I'm new here, are all the issues fixed?

@PALASH2201
Copy link

PALASH2201 commented Oct 1, 2024 •
edited
Loading

I went to through this analysis https://sonarcloud.io/project/issues?impactSeverities=HIGH&resolved=false&id=iluwatar_java-design-patterns , mongoDB credentials were hardcoded, so I have added .env file and tested the changes, I have also added and updated dependencies in pom.xml. I have tested and it has passed. How to proceed now?

@PALASH2201
Copy link

Should I issue a PR for your review?

@PALASH2201
Copy link

@iluwatar I apologize for pinging you, but is this issue solved already, I have made some changes, just need your approval

@code-akanksha code-akanksha mentioned this issue Oct 12, 2024
Open
@iluwatar iluwatar moved this from Todo to In Progress in Java Design Patterns project Oct 13, 2024
@PALASH2201 PALASH2201 linked a pull request Oct 13, 2024 that will close this issue
Open
@SalmaAzeem
Copy link
Contributor

Hello, @iluwatar.
There are still 20 high issues as you can see in this recent analysis, can you assign me this task to fix them.
https://sonarcloud.io/project/issues?impactSeverities=HIGH&issueStatuses=OPEN%2CCONFIRMED&id=SalmaAzeem_java-design-patterns
Thanks!

@mohymohysaleh
Copy link

mohymohysaleh commented Dec 1, 2024 •
edited
Loading

Hello @iluwatar ,
I came across several maintainability high severity issues titled "This class is part of one cycle containing 2 classes"
and would like to work on them.
https://sonarcloud.io/project/issues?impactSeverities=HIGH&issueStatuses=OPEN%2CCONFIRMED&id=iluwatar_java-design-patterns
Could you kindly assign these issues to me?

Thanks in advance!

@SalmaAzeem SalmaAzeem mentioned this issue Dec 3, 2024
Merged
@PlumHeadd
Copy link

Hello @iluwatar , I’d like to work on this issue. Could you assign it to me?

@haneen-elghawy
Copy link

haneen-elghawy commented Dec 6, 2024 •
edited
Loading

Hello @iluwatar,

I noticed several medium severity issues titled:
"[Swap these 2 arguments so they are in the correct order: expected value, actual value.]"
https://sonarcloud.io/project/issues?impactSeverities=MEDIUM&impactSoftwareQualities=MAINTAINABILITY&issueStatuses=OPEN%2CCONFIRMED&id=iluwatar_java-design-patterns

Could you please assign these issues to me? I’d love to work on resolving them.

Thank you!

iluwatar pushed a commit that referenced this issue Dec 7, 2024
@SalmaAzeem
fix: Reduce High severity issues reported by SonarCloud #2865 (#3103)
297e429 
* fix: add UnsupportedOperationException in KingsHand and GameLoopTest

* refactor: update DatabaseService to use constant for BINARY_DATA and remove obsolete test files

* refactor: update timePasses method in KingsHand

* refactor CandyGame.java

* refactor: simplify boundary checks in CandyGame

* feat: add getters for type and points in Candy class and initialize logger in CandyGame

* remove class and logger initialization in CandyGame

* Modify CandyGame.java

* fix Checkstyle violations

* Remove generic wildcard type in ThreatAwareSystem
mohymohysaleh added a commit to mohymohysaleh/java-design-patterns that referenced this issue Dec 8, 2024
@mohymohysaleh
Solved Maintainability high severity issues from SonarCloud iluwatar#…
4d8833a 
…2865

Created interfaces to solve the cycling between the classes
( Hayes, ZoomVisitor, CommanderUnit)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SalmaAzeem SalmaAzeem

@PALASH2201 PALASH2201

@haneen-elghawy haneen-elghawy

@mohymohysaleh mohymohysaleh

Labels
epic: code quality info: good first issue info: help wanted
Projects
Java Design Patterns project
Status: In Progress
Milestone
No milestone
8 participants
@iluwatar @krishnagjsForGit @k1w1dev @SalmaAzeem @PALASH2201 @PlumHeadd @haneen-elghawy @mohymohysaleh