-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doc search #171
Add doc search #171
Conversation
Use https://docsearch.algolia.com/ for the search service. Closes #164.
3f2a951
to
e60d8b2
Compare
hey this looks cool! Will we get any kind of info how many searches we get (since we only have 10k per month free)? Also I couldn't find what data they will collect from our users. |
According to https://www.algolia.com/for-open-source/, they give you 200K search queries per month.
See https://docsearch.algolia.com/docs/faq/#what-data-are-you-collecting. Judging by the dashboard, they don't track by default: you need to explicitly enable tracking. |
Hey @emilmelnikov, great - thank you very much for digging up those links, and also pointing me to their OSS tier! Do we need to make people aware that by searching, they are sending their information to a third party? Can users opt out somehow? |
When you search something, the search widget contains "Search by Algolia" logo.
I don't think it's possible without sacrificing good UX. |
so far so good.
so if I read this correctly, there will not be any cookies involved if we do not switch on this tracking, so for a user currently nothing would change other than enhanced features on the website. |
Yes, I checked the cookie list, and it was empty (well, not really, but all the cookies were from the Twitter widget). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, let's merge it now that you're back :) @emilmelnikov
Use https://docsearch.algolia.com/ for the search service.
Closes #164.