Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bootstrap classes to Markdown tables #152

Merged
merged 4 commits into from
Nov 18, 2020
Merged

Add Bootstrap classes to Markdown tables #152

merged 4 commits into from
Nov 18, 2020

Conversation

emilmelnikov
Copy link
Member

Markdown tables are generated without any classes, but Bootstrap
requires adding .table classes in order for a table to be styled.

Closes #151

@emilmelnikov
Copy link
Member Author

For some reason, a lot of lines in the changed documents had trailing whitespaces, so please ignore whitespace changes in the diff (git diff -w or check a checkbox in the GitHub diff UI).

Copy link
Contributor

@k-dominik k-dominik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks cool! Awesome, the only issue I found is the following:

table

is it possible to wrap those texts there (somehow enforce the table to the content width?)

Also could you extract the whitespace changes into a separate commit?

Markdown tables are generated without any classes, but Bootstrap
requires adding `.table` classes in order for a table to be styled.

Closes #151
@emilmelnikov
Copy link
Member Author

emilmelnikov commented Oct 22, 2020

is it possible to wrap those texts there (somehow enforce the table to the content width?)

Only if some text is out of the <pre> elements.

I've changed the text and formatting, but I'm not sure what the original documentation author meant (that is, where are identifiers_in_actual_data and where are their descriptions). @k-dominik could you make sure that the meaning is the same?

image

@k-dominik
Copy link
Contributor

Hi @emilmelnikov , the table looks great! As for the Object IDs in that table: There are actually no identifiers in the data (I checked :o, e.g. here in case you want to make your eyes bleed). So this is more or less arbitrary. Maybe rename the Object IDs column in the table to Columns?

@emilmelnikov
Copy link
Member Author

emilmelnikov commented Nov 18, 2020

I also added a missing MultiFrameMoves dataset, and a note that we also have energy datasets.

image

@k-dominik
Copy link
Contributor

k-dominik commented Nov 18, 2020

that's cool. Could you check whether it is actually possible to generate these fields in export files? I have no clue how MultiFrameMoves are supposed to happen. (Quickly tried, but didn't manage to generate one).

Also about the energies: I would not know where these should come from in manual tracking...

@emilmelnikov
Copy link
Member Author

Could you check whether it is actually possible to generate these fields in export files? I have no clue how MultiFrameMoves are supposed to happen.

I don't really understand very well what is going on in the manual tracking code, but it seems that multi-frame merges happen on this condition: https://github.com/ilastik/ilastik/blob/a7ee78d7936ed573b10c6ff4d8733e1f126a00ea/ilastik/applets/tracking/manual/manualTrackingGui.py#L938

Also about the energies: I would not know where these should come from in manual tracking...

Yes, I looked at the code, and in manual tracking we always write 0 energy for each event.

Copy link
Contributor

@k-dominik k-dominik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 the tracking docs finally look somewhat bearable on mobile devices...

@emilmelnikov emilmelnikov merged commit be0293c into ilastik:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make tables pretty
2 participants