Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To Simplify the Cancelsale function by removing unnecessary code #7 #27

Closed
wants to merge 8 commits into from
Closed

To Simplify the Cancelsale function by removing unnecessary code #7 #27

wants to merge 8 commits into from

Conversation

Ansh-Agrawal1817
Copy link

Resolved #7
Screenshot 2024-03-15 at 7 32 31 PM

@Ansh-Agrawal1817
Copy link
Author

Enhanced the cancelsale function by adding various functionalities like checking whether the NFT exists or not,
transferring the NFT back to the seller, refunding the price.

@TechWizard9999
Copy link
Contributor

@Ansh-Agrawal1817
Great job! However your code formatting may lead to a re-entrancy attack when you declare the address at the end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
accepted-5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

To Simplify the Cancelsale function by removing unnecessary code
2 participants
@Ansh-Agrawal1817 @TechWizard9999