Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To Simplify the Cancelsale function by removing unnecessary code #7

Open
TechWizard9999 opened this issue Mar 14, 2024 · 0 comments
Open

To Simplify the Cancelsale function by removing unnecessary code #7

TechWizard9999 opened this issue Mar 14, 2024 · 0 comments
Labels
medium

Comments

@TechWizard9999
Copy link
Contributor

The current implementation of the cancelSale function contains redundant code that can be eliminated to enhance simplicity and optimize performance
vishal18713 added a commit to vishal18713/realty that referenced this issue Mar 15, 2024
@vishal18713
Solved iiitl#1, iiitl#2, iiitl#3, iiitl#7, iiitl#8, iiitl#10
8ab6da7 
- [x] Added Memory keyword for string datatype
- [x] Memory usage Optimization
- [x] Made function payable and transferred nft after successful
  transfer of funds to the user
- [x] remove unnecessary code and optimized the function for seller
- [x] added visiblity keyword external for ERC721 interface
- [x] Completed the deployment script of Contract.sol
This was referenced Mar 15, 2024
Closed
Closed
Ansh-Agrawal1817 added a commit to Ansh-Agrawal1817/realty that referenced this issue Mar 15, 2024
@Ansh-Agrawal1817
Issue iiitl#7 enhanced cancelsale
01db908
Ansh-Agrawal1817 added a commit to Ansh-Agrawal1817/realty that referenced this issue Mar 15, 2024
@Ansh-Agrawal1817
Issue iiitl#7 enhanced cancelsale
4e0e3be
@Ansh-Agrawal1817 Ansh-Agrawal1817 mentioned this issue Mar 15, 2024
Closed
Dishant-garg added a commit to Dishant-garg/realty that referenced this issue Mar 16, 2024
@Dishant-garg
Solved issue iiitl#7
d525dc5
@Dishant-garg Dishant-garg mentioned this issue Mar 16, 2024
Closed
Dishant-garg added a commit to Dishant-garg/realty that referenced this issue Mar 17, 2024
@Dishant-garg
Resolved issue iiitl#7
61853ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

To Simplify the Cancelsale function by removing unnecessary code #7 Ansh-Agrawal1817/realty
1 participant
@TechWizard9999