Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 'bought' Function to Stop Direct Payment to Seller #3 #26

Closed
wants to merge 5 commits into from

Conversation

Ansh-Agrawal1817
Copy link

Resolved #3
Made the function payable to accept ether.
Added functionality to send funds to the contract(user) instead of the seller.
Screenshot 2024-03-15 at 7 02 59 PM

@Ansh-Agrawal1817
Copy link
Author

made the function payable to accept ether.
transferred the funds to contract instead of seller.

@TechWizard9999
Copy link
Contributor

@Ansh-Agrawal1817
There is still error in your code
Please re-check it

@Ansh-Agrawal1817
Copy link
Author

The require tag is used so as to check whether the transfer to seller is successful or not.
The transfer of the NFT is done and finally the property token is removed from the property sale list.

@Ansh-Agrawal1817
Copy link
Author

Screenshot 2024-03-16 at 2 55 17 PM

@TechWizard9999
Copy link
Contributor

@Ansh-Agrawal1817
But the code doesnt correct the logic , To be precise the seller is not payable

@Ansh-Agrawal1817
Copy link
Author

@TechWizard9999
Kindly review it now.
Screenshot 2024-03-16 at 11 49 29 PM

@TechWizard9999
Copy link
Contributor

@Ansh-Agrawal1817
Nice one!! Always make sure to have payable....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve 'bought' Function to Stop Direct Payment to Seller
2 participants