Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the mouse interaction in the Editor's spell selection and castle properties windows #9357

Merged
merged 7 commits into from
Dec 22, 2024
Merged

Fix the mouse interaction in the Editor's spell selection and castle properties windows #9357

merged 7 commits into from
Dec 22, 2024

Conversation

oleg-derevenetz
Copy link
Collaborator

fix #9354

@oleg-derevenetz oleg-derevenetz added bug Something doesn't work ui UI/GUI related stuff labels Dec 19, 2024
@oleg-derevenetz oleg-derevenetz added this to the 1.1.5 milestone Dec 19, 2024
@oleg-derevenetz oleg-derevenetz marked this pull request as ready for review December 19, 2024 19:42
@Branikolog
Copy link
Collaborator

Hi, @oleg-derevenetz !
I've checked the PR and the issue for shrines and pyramids is fixed. 👍
I've noticed the same issue for castle window. Should I create a separate issue for that or these are similar problems and could be fixed within a single PR?
image

@oleg-derevenetz
Copy link
Collaborator Author

Should I create a separate issue for that or these are similar problems and could be fixed within a single PR?

I (hopefully) fixed the castle properties window as well.

@oleg-derevenetz oleg-derevenetz changed the title Fix the mouse interaction in the Editor's Spell selection window Fix the mouse interaction in the Editor's spell selection and castle properties windows Dec 20, 2024
@ihhub ihhub merged commit cb90152 into ihhub:master Dec 22, 2024
20 checks passed
@ihhub
Copy link
Owner

ihhub commented Dec 22, 2024

@oleg-derevenetz , thank you so much for the fix!

@oleg-derevenetz oleg-derevenetz deleted the editor-spell-selection-mouse-fix branch December 22, 2024 08:48
BlackBred added a commit to BlackBred/fheroes2 that referenced this pull request Dec 22, 2024
@BlackBred
Merge branch 'master' into Autosave
9d5a30b 
* master:
  Update issue templates
  Add ability to setup Secondary Skills in Witch's Hut inside the Editor (ihhub#9351)
  Fix the mouse interaction in the Editor's spell selection and castle properties windows (ihhub#9357)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Districh-ru Districh-ru Districh-ru approved these changes

@ihhub ihhub ihhub approved these changes

@Branikolog Branikolog Awaiting requested review from Branikolog

Assignees

@oleg-derevenetz oleg-derevenetz

Labels
bug Something doesn't work ui UI/GUI related stuff
Projects
None yet
Milestone
1.1.5
4 participants
@oleg-derevenetz @Branikolog @ihhub @Districh-ru