Cannot disembark near the rock

[Branikolog]

Preliminary checks

• I've checked that there aren't other open issues on the same topic.
• I've checked that this issue is reproducible on the latest snapshot build.

Platform

Windows

Describe the bug

Hero cannot unboard on a tile above the rock.

2024-09-27.16-52-41.mp4

The issue is valid only for fheroes2 resurrection maps.

The same object in the original map allows hero to disembark near it.

Save file

None.

Additional info

No response

[ihhub]

I believe this is a problem with different object passability.

[Branikolog]

Hi, @ihhub
The issue is valid only for heroes on boat. Hero can step on that tile on horse without any problem. In the original game and in fheroes2 on the original map hero can inboard there too.

[Branikolog]

The problem occurs for all tall objects. The most noticeable case is lighthouses. It has even 2 unreachable cells above them:

2024-10-22.12-39-17.mp4

[Branikolog]

The issue is valid for .fh2 maps only. In the OG maps hero can disembark on those tiles behind the lighthouse.
Here're 2 save files for the OG map and fh2 map:
Boarding save.zip

[ihhub]

@Branikolog , in the original game the tile is marked as "Beach" while for fh2 map it is marked as Lighthouse. Both solutions are invalid :)

[ihhub]

For coast we have to verify not the main type of a tile (which is done currently) but whether it is accessible from sea by passability. I believe this affects not only hero players but pathfinding and AI actions.