Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combat screen, Auto combat and Instant Combat windows, change the text for better understanding #9094

Open
1 task done
LeHerosInconnu opened this issue Sep 8, 2024 · 2 comments
Labels
improvement New feature, request or improvement

Comments

@LeHerosInconnu
Copy link

Preliminary checks

Describe the problem requiring a solution

When the user presses the "Q" key on the keyboard (to instantly resolve the combat and exit the combat screen), a window is displayed to allow him to validate his action or not.
However, the text is not clear.

Describe the possible solution

In fheroes2:

Auto and instant combat modes 001

I suggest displaying the following text:

"Are you sure you want to resolve the combat in instant combat mode?"

Instead of:

"Are you sure you want to finish the battle in auto mode?"

I also suggest changing the text of the window displayed when the user presses the “AUTO” button to continue the combat in automatic mode.

In fheroes2:

Auto and instant combat modes 002

I suggest displaying the following text:

"Are you sure you want to enable the auto combat mode?"

Instead of:

"Are you sure you want to enable auto combat?"

And to change the text of the window displayed when the user presses the “AUTO” button to interrupt the combat in automatic mode.

In fheroes2:

Auto and instant combat modes 002a

I suggest displaying the following text:

"Are you sure you want to interrupt the auto combat mode?"

Instead of:

"Are you sure you want to interrupt the auto combat?"

Additional info

No response

@LeHerosInconnu LeHerosInconnu added the improvement New feature, request or improvement label Sep 8, 2024
@oleg-derevenetz
Copy link
Collaborator

oleg-derevenetz commented Sep 13, 2024

I have to explain the difficulty with this proposal (and with #9095). We already have the "finish the battle in auto mode" hotkey definition in the fheroes2.key, and if the wording in the game and in the hotkey config file will differ significantly, this may confuse the user. At the same time, the configuration files must remain backward compatible, so we can't just change the wording back and forth without further thought. The same applies to other similar hotkey-related actions.

@LeHerosInconnu
Copy link
Author

I have opened a related discussion to this: #9100.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature, request or improvement
Projects
None yet
Development

No branches or pull requests

2 participants