Battle: rainbow is too slow

[fheroes2bugs]

Preliminary checks

• I've checked that there aren't other open issues on the same topic.

Describe the problem requiring a solution

When playing at high speed, slow rainbow dramatically increases the duration of the battle.

270078303-f7fa3b47-c03f-4441-8b19-c65978559934.mov

Describe the possible solution

Make rainbow speed to depend on chosen speed of the batte.

Additional info

No response

[oleg-derevenetz]

Make rainbow speed to depend on chosen speed of the batte.

If you take a closer look, you will see that the rainbow animation speed already depends on the battle speed setting. But rainbow animation doesn't disappear until the "good luck" sound ends. As far as I understand, this was the consensus at the time when it was implemented because the other options looked worse.

[Branikolog]

@oleg-derevenetz , hello.
Indeed, the "good luck" sound is quite a long one and without waiting until it finishes, battle sounds are turning into a cacophony. Current behaviour was implemented intentionally. However, for the higher speeds I think a slight change could be made allowing to proceed the battle a few moments before sound finishes. Like after 80-90% of the sound was played already (for 10 and 9 respectively). It will slightly interfere with all next sounds, but would make the perception battle speed more matching.

[ihhub]

I'm moving this to the discussion topic as we had chats about this in the past.

[fheroes2bugs]

So what are the pros of slow rainbow?
Leadership (double turn) is fast, but luck (rainbow) is slow, there is no logic in it.

[Branikolog]

So what are the pros of slow rainbow? Leadership (double turn) is fast, but luck (rainbow) is slow, there is no logic in it.

Indeed. We need a consistent logic for both of these events. Either make morale event last longer, or don't wait until luck sound finishes to proceed other battle actions.