Discarding artifacts feature: need buttons

[chrisbigart]

Hi, I'm working on a feature to allow discarding artifacts (with the exception of magic book, fizbin, tax lien, and hideous mask) in the hero screen and after a victory:

The code is pretty much ready to go, but I need help with the buttons. I don't know if a button with an icon would be better, or just simply a button with the text 'Discard' on it. Maybe for the victory condition, there could be 'Discard' and 'Keep' instead of 'Okay' and a discard button. In any case, if someone could help me create these or provide them, then I'll be able to submit this change. Thanks!

[ihhub]

Hi @chrisbigart , thanks for opening a discussion before proposing an implementation. From what see many people will be against it as it's breaking game's logic. I'm sure some people in our team will share the same opinion so I'll just wait to hear them🙂

[LeHerosInconnu]

Hello @Branikolog,

It's better to look at it that way. :)

[ihhub]

If we want to add such option then I'd like to ask how AI would behave in this case? I'm the proposed changes cover only human player. Another issue to solve: why negative artifacts can't be removed? It needs a proper explanation from the game. Also we have PoL artifacts which have positive and negative effects. How are we going to handle them?

[LeHerosInconnu]

Hello @ihhub,

If we want to add such option then I'd like to ask how AI would behave in this case? I'm the proposed changes cover only human player.

I think the AI should keep all artifacts (and distribute them intelligently among its heroes); a bad artifact in one case can be a good artifact in another.
It should just be an improvement for the human player.
Later, when an extended inventory could be implemented (#2995), this will no longer be a problem, because all artifacts can be kept, and active or not depending on the case.

Another issue to solve: why negative artifacts can't be removed? It needs a proper explanation from the game.

Cursed artifacts have to remain cursed.
And so it should not be possible to get rid of them easily, or at least not in this way, they should remain constraining.
Also, I think there is a kind of bug in the original game by the possibility to be able to transfer them to another hero.
That's why I added this option in my mod: #3078.

The button should be grayed out when the artifact is a cursed artifact, with a right-click information window indicating why (e.g. "A cursed artifact cannot be discarded.").

Also we have PoL artifacts which have positive and negative effects. How are we going to handle them?

PoL artifacts which positive and negative effects are considered cursed artifacts (they can be removed when the hero visits the Alchemist's Tower).

These PoL artifacts are considered cursed artifacts:

• Arm of the Martyr
• Broach of Shielding
• Heart of Fire
• Heart of Ice

[oleg-derevenetz]

Hi all,

I agree with @Branikolog. There is already lots of "improvements" in the game from the previous team, not all of them are well thought out and break the game mechanics (or even doesn't work properly), so we regularly get rid of certain options.

However, there are also very successful ones - for example, option that shows order of units in the battle (I just keep it turned on all the time) or option that allows HoMM3-like "wait" mechanics in battle (even though it needs some polishing in regard to the UI - current combination of "wait" and "skip" buttons doesn't look too nice).

Therefore, I'd suggest to carefully consider new "improvement" options and all possible outcomes before implementing them.

[LeHerosInconnu]

Hello @oleg-derevenetz,

The problem is that one player will like one option and not another and it will be the opposite for another player.

This is the principle of options, the player chooses the options he likes.
But it is true that only interesting/requested options should be offered to the player.

Later, I will refine my opinion for the options already present in fheroes2 that I think will not be used by the players in this thread: #1272.