Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimension of videos are not validated #190

Open
mikefranken opened this issue May 15, 2023 · 5 comments
Open

Dimension of videos are not validated #190

mikefranken opened this issue May 15, 2023 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mikefranken
Copy link

I get Skipping image analysis because ImageMagick or Vips doesn't support the file, and the Meta class used for validation just seems to support images, not video.

Or am I missing something?

@mikefranken mikefranken changed the title Dimension of images are not validated Dimension of videos are not validated May 15, 2023
@igorkasyanchuk
Copy link
Owner

I was never trying to check how if works or not with video, but you saying it doesn't work - than we need a PR with a fix :)

do you think you can check this and implement?

@igorkasyanchuk igorkasyanchuk added the help wanted Extra attention is needed label May 15, 2023
@mikefranken
Copy link
Author

sure, see #191

@igorkasyanchuk
Copy link
Owner

here is a quick PR to check the logic https://github.com/igorkasyanchuk/active_storage_validations/pull/192/files
Your PR is too early to merge. I see that validation works, so I would just ask to spend more time.

@Mth0158 Mth0158 added the enhancement New feature or request label Dec 1, 2023
@Mth0158
Copy link
Collaborator

Mth0158 commented Dec 1, 2023

@igorkasyanchuk do you need help on this one? I could dive into possible solutions

@igorkasyanchuk
Copy link
Owner

sure, if you have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants