Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future warning in trading_ig\rest.py #330

Closed
Leotheone opened this issue Apr 17, 2024 · 5 comments
Closed

Future warning in trading_ig\rest.py #330

Leotheone opened this issue Apr 17, 2024 · 5 comments

Comments

@Leotheone
Copy link

Leotheone commented Apr 17, 2024

Hello,

For all intents and purposes, since the latest library version upgrades, this causes futureWarnings in fetch_historical_prices_by_epic, fetch_historical_prices_by_epic_and_num_points and fetch_historical_prices_by_epic_and_date_range
functions located in trading_ig\rest.py :

...\trading_ig\rest.py:1801: FutureWarning: Downcasting object dtype arrays on .fillna, .ffill, .bfill is deprecated and will change in a future version. Call result.infer_objects(copy=False) instead. To opt-in to the future behavior, set pd.set_option('future.no_silent_downcasting', True) data["prices"] = data["prices"].fillna(value=np.nan)

...\trading_ig\rest.py:1823: FutureWarning: Downcasting object dtype arrays on .fillna, .ffill, .bfill is deprecated and will change in a future version. Call result.infer_objects(copy=False) instead. To opt-in to the future behavior, set pd.set_option('future.no_silent_downcasting', True) data["prices"] = data["prices"].fillna(value=np.nan)

...\trading_ig\rest.py:1887: FutureWarning: Downcasting object dtype arrays on .fillna, .ffill, .bfill is deprecated and will change in a future version. Call result.infer_objects(copy=False) instead. To opt-in to the future behavior, set pd.set_option('future.no_silent_downcasting', True) data["prices"] = data["prices"].fillna(value=np.nan)

Best regards

@bug-or-feature
Copy link
Member

Thanks for your interest in the project.

Please provide more information: what upgrades? what versions of which libraries are you using? etc

It is all documented here

@Leotheone
Copy link
Author

Thanks so much for your reply and for all the work done so far.
The shared sources have been a great help to me for several years!

You will find below the information that I hope is necessary and sufficient to produce the problem:

Used versions :

Python 3.10
trading-ig 0.0.22

Sources for producing a future warning :

from datetime import datetime, timedelta
from trading_ig import IGService

username = "xxx"
password = "xxx"
api_key = "xxx"
acc_type = "DEMO"
acc_number = "xxx"

ig_service = IGService(username, password, api_key, acc_type)
ig_service.create_session()

epic = 'IX.D.NASDAQ.IFE.IP'
resolution = 'H'
end_date = datetime.today()
start_date = end_date + timedelta(hours=-6)
session = None

response = ig_service.fetch_historical_prices_by_epic_and_date_range(epic, resolution, start_date, end_date, session)
print(response)

@bug-or-feature
Copy link
Member

@Leotheone thanks for the code snippet - but you missed the most important (crucial) bit of information - your pandas version. The warnings you are seeing are due to your use of Pandas 2.2.0 which was released in January 2024. That's why we ask for dependencies and their versions when creating an issue

@femtotrader thanks for the clarification

@bug-or-feature
Copy link
Member

Closing, merged with #329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants